abdera-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James M Snell <jasn...@gmail.com>
Subject Re: Advice on implementing an APP server
Date Wed, 21 Feb 2007 17:05:11 GMT
By a wierd twist of fate I had to take a look at that class today anyway
so I went ahead and made some changes.

The reason TargetType is not an Enum is because we need to be able to
plug in new types of targets later on, as well as allow specific
implementations to add their own targets in via subclassing.  Enums
can't be subclassed.

- James

Adam Constabaris wrote:
> James M Snell wrote:
>> I can take a look at this or.... if you're so inclined... patches are
>> welcome :-)
> I didn't want to assume it was supposed to work the way I initially
> tried (note to self: get confident, stupid!) Would a refactor of TargetType
> to a JDK1.5 enum be acceptable?  I assume that works for 1.4
> compatibility through retroweaver, but it might impact extensibility.
> As I work my way through my implementation, I'm taking notes for a
> larger document.  Right now, as it happens, I'm working on Provider, so
> I'll work what I end up with (what works here?  I favor DocBook, but I
> can easily just submit the HTML) and submit that first.
> cheers,
> AC
>> - James
>> Adam Constabaris wrote:
>>> [snip]
>>> (aside: I would have thought that TargetType.get(entry.getValue()) would
>>> work, but I ran into identity vs. equality problems, even when I
>>> interned the strings)

View raw message