accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #1002: Fix implicit casts of numbers & int multiplication
Date Fri, 01 Mar 2019 17:33:37 GMT
milleruntime commented on a change in pull request #1002: Fix implicit casts of numbers &
int multiplication
URL: https://github.com/apache/accumulo/pull/1002#discussion_r261692236
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ReplicationClient.java
 ##########
 @@ -56,7 +56,7 @@
       log.debug("Could not get ReplicationCoordinator connection to {}, will retry",
           context.getInstanceName());
       try {
-        Thread.sleep(attempts * 250);
+        Thread.sleep((long) attempts * 250);
 
 Review comment:
   I just realized this is another false positive, they should be able to detect since the
loop control variable is bounded.  I will report it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message