accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on issue #1005: Fix #949 handle WAL failure to prevent stuck Accumulo
Date Fri, 01 Mar 2019 18:41:30 GMT
keith-turner commented on issue #1005: Fix #949 handle WAL failure to prevent stuck Accumulo
URL: https://github.com/apache/accumulo/pull/1005#issuecomment-468767246
 
 
   This is a nice find. What do you think of the following approach?
   
    ```java
   // code inside the loop
               log.debug("Creating next WAL");
               try {
                  alog = new DfsLogger(conf, syncCounter, flushCounter);
                  alog.open(tserver.getClientAddressString());
               } catch (Exception e) {
                  // failed to open log, its not advertised in ZK yet so its safe to delete
it
                  // TODO attempt to delete file
                  // TODO continue loop
               }
               String fileName = alog.getFileName();
               log.debug("Created next WAL " + fileName);
               newMarkerAttempted = true;
               try {
                   tserver.addNewLogMarker(alog);
               } catch (Exception e) {
                   // something went wrong advertising the log in ZK.... its possible it now
exist in ZK even though an exception occurred.  
                   // TODO attempt to mark closed and copy your comment about GC and tserver
dying
                   // TODO continue loop
               }
               while (!nextLog.offer(alog, 12, TimeUnit.HOURS)) {
                  log.info("Our WAL was not used for 12 hours: " + fileName);
               }
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message