accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner commented on a change in pull request #999: fixes #998 handle splitting tablet with no data and files
Date Thu, 07 Mar 2019 16:38:34 GMT
keith-turner commented on a change in pull request #999: fixes #998 handle splitting tablet
with no data and files
URL: https://github.com/apache/accumulo/pull/999#discussion_r263466396
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -1635,6 +1635,17 @@ private SplitRowSpec findSplitRow(Collection<FileRef> files)
{
       return null;
     }
 
+    if (keys.isEmpty()) {
+      log.info("Cannot split tablet " + extent + ", files contain no data for tablet.");
+
+      // set the following to keep tablet from attempting to split until the tablets set
of files
+      // changes.
+      sawBigRow = true;
+      timeOfLastMinCWhenBigFreakinRowWasSeen = lastMinorCompactionFinishTime;
 
 Review comment:
   I will do that as a follow on change.  Do not want them in the same commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message