accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1032: fixes #1031 fix concurrency bug and remove unused code
Date Thu, 14 Mar 2019 22:31:44 GMT
ctubbsii commented on a change in pull request #1032: fixes #1031 fix concurrency bug and remove
unused code
URL: https://github.com/apache/accumulo/pull/1032#discussion_r265791365
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -1989,7 +1985,9 @@ private CompactionStats _majorCompact(MajorCompactionReason reason)
           CompactionEnv cenv = new CompactionEnv() {
             @Override
             public boolean isCompactionEnabled() {
-              return Tablet.this.isCompactionEnabled();
+              // avoid calling isClosing() because its synchronized and this is called frequently
in
+              // compaction
+              return closeState != CloseState.CLOSING;
 
 Review comment:
   > If I were to make a larger change would you be able to give it a thorough review?
   
   I think it's fine for 1.9. Could do follow-on in 2.0 to do a more thorough analysis of
whether these need to be synchronized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message