accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1034: Fixes #933 - RuntimeException while stopping Accumulo
Date Thu, 14 Mar 2019 22:41:00 GMT
ctubbsii commented on a change in pull request #1034: Fixes #933 - RuntimeException while stopping
Accumulo
URL: https://github.com/apache/accumulo/pull/1034#discussion_r265793602
 
 

 ##########
 File path: start/src/main/java/org/apache/accumulo/start/classloader/vfs/AccumuloReloadingVFSClassLoader.java
 ##########
 @@ -199,6 +200,9 @@ public AccumuloReloadingVFSClassLoader(String uris, FileSystemManager
vfs,
    * thread
    */
   public void close() {
+    for (FileObject file : Arrays.asList(this.files)) {
+      monitor.removeFile(file);
 
 Review comment:
   I was curious about that, too. I'm not even sure we ever bother to close this ClassLoader,
so I'm not even sure this would run.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message