ace-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthijs Hendriks (Commented) (JIRA)" <>
Subject [jira] [Commented] (ACE-259) Support for metatype schema v1.1 (and beyond)
Date Fri, 13 Apr 2012 12:53:16 GMT


Matthijs Hendriks commented on ACE-259:

A side note here: the recognizer checks the first attribute of the config file, of which it
assumes it is the MetaData. This, however, is a really naive implementation, as Bram and I
found out. If, before the MetaData attribute a comment is placed the recognizer will see the
comment as the first attributes, generating a NullPointerException and therefore leaving it
unrecognized... The fix should, obviously, find the MetaData attribute rather than simply
the first.

This 'breaks', for example, since the comment is used:
<!-- Example platform scope configuration -->
<MetaData ...>
> Support for metatype schema v1.1 (and beyond)
> ---------------------------------------------
>                 Key: ACE-259
>                 URL:
>             Project: ACE
>          Issue Type: Improvement
>            Reporter: Bram de Kruijff
>            Assignee: Bram de Kruijff
> The configuration helper implementation hardcodes a check for "",
but v1.1 and v.1.2 are also valid schemas. AFAICS there is no regression risk in accepting
v1.1 and 1.2 as long as the provider autoconf rp can handle them. Unfortunatly, there is no
way to express version constraints on this level.
> So..
> 1) Create seperate helpers for v1.1. & v1.2
> 2) Make this helper accept v1.1 & v.1.2
> 3) Rely on org.apache.felix.metatype.MetaDataReader to determine validity
> IMHO option 1 is unnecessarily heavy, option 2 is the easiest fix and option 3 the most
elegant and robust solution. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message