activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuco...@apache.org
Subject [1/2] activemq-artemis git commit: ARTEMIS-1980 Warn on failed check of table existence should be info
Date Fri, 02 Nov 2018 14:19:43 GMT
Repository: activemq-artemis
Updated Branches:
  refs/heads/master 1ffde789c -> a2264c528


ARTEMIS-1980 Warn on failed check of table existence should be info

DB2 metadata checks should erroneously report stale table existence on
not existing/just deleted table, making the subsequent warning logs
of failed SELECT COUNT useless and scaring: should be better to let
them lowered to INFO level


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/46542fb2
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/46542fb2
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/46542fb2

Branch: refs/heads/master
Commit: 46542fb230a31d621be9cdf4140df998d6dc3903
Parents: 1ffde78
Author: Francesco Nigro <nigro.fra@gmail.com>
Authored: Thu Jul 12 15:14:37 2018 +0200
Committer: Clebert Suconic <clebertsuconic@apache.org>
Committed: Fri Nov 2 10:19:35 2018 -0400

----------------------------------------------------------------------
 .../artemis/jdbc/store/drivers/AbstractJDBCDriver.java        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/46542fb2/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
----------------------------------------------------------------------
diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
index ceb0967..2118942 100644
--- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
+++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
@@ -242,7 +242,12 @@ public abstract class AbstractJDBCDriver {
                   }
                }
             } catch (SQLException e) {
-               logger.warn(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't verify
the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
+               //that's not a real issue and do not deserve any user-level log:
+               //some DBMS just return stale information about table existence
+               //and can fail on later attempts to access them
+               if (logger.isTraceEnabled()) {
+                  logger.trace(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't
verify the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
+               }
                try {
                   connection.rollback();
                } catch (SQLException rollbackEx) {


Mime
View raw message