airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Christie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2341) JDBC username and password should be URL encoded when put into JDBC URL
Date Mon, 20 Mar 2017 15:43:41 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932860#comment-15932860
] 

Marcus Christie commented on AIRAVATA-2341:
-------------------------------------------

I'll also note that I tried to workaround this by URL encoding the password in airavata-server.properties.
This almost worked. The code in ExperimentCatalogInitUtil.java was apparently able to connect
to the database, but then the openjpa connection later on was not able to connect. My guess
is that the openjpa connection properties don't need or don't unescape the jdbc connection
URL (oddly, it appears to use comma as a query parameter delimiter, see https://github.com/apache/airavata/blob/8469effce22ffe3a54255d3920ee33b9d9035c06/modules/registry/registry-core/src/main/java/org/apache/airavata/registry/core/experiment/catalog/ExpCatResourceUtils.java#L47-L47).

> JDBC username and password should be URL encoded when put into JDBC URL
> -----------------------------------------------------------------------
>
>                 Key: AIRAVATA-2341
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2341
>             Project: Airavata
>          Issue Type: Bug
>          Components: Registry API
>    Affects Versions: 0.17
>            Reporter: Marcus Christie
>
> In several places in the code, JDBC usernames and passwords are put into JDBC URLs without
properly encoding them for URLs.  For example:
> https://github.com/apache/airavata/blob/43b3757d6c1b759a47603189e0ac0ad97339fd8b/modules/registry/registry-server/registry-api-service/src/main/java/org/apache/airavata/registry/api/service/util/ExperimentCatalogInitUtil.java#L68
> The ampersand character is an example of a character that needs to be encoded because
it delimits URL query parameters.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message