airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machristie <...@git.apache.org>
Subject [GitHub] airavata pull request #111: [AIRAVATA-2385] Checking for duplicate gateway r...
Date Wed, 07 Jun 2017 18:08:57 GMT
Github user machristie commented on a diff in the pull request:

    https://github.com/apache/airavata/pull/111#discussion_r120700426
  
    --- Diff: airavata-services/profile-service/profile-service-server/src/main/java/org/apache/airavata/service/profile/handlers/TenantProfileServiceHandler.java
---
    @@ -72,7 +72,9 @@ public String getAPIVersion(AuthzToken authzToken) throws TenantProfileServiceEx
         @SecurityCheck
         public String addGateway(AuthzToken authzToken, Gateway gateway) throws TenantProfileServiceException,
AuthorizationException, TException {
             try {
    -            gateway = tenantProfileRepository.create(gateway);
    +            if (!checkDuplicate(gateway)) {
    --- End diff --
    
    If there is a duplicate then I think the code should throw a TenantProfileServiceException
with an error message explaining that there is a duplicate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message