airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machristie <...@git.apache.org>
Subject [GitHub] airavata-php-gateway pull request #61: [AIRAVATA-2473] Mail notification sen...
Date Tue, 04 Jul 2017 15:39:40 GMT
Github user machristie commented on a diff in the pull request:

    https://github.com/apache/airavata-php-gateway/pull/61#discussion_r125499238
  
    --- Diff: app/controllers/AdminController.php ---
    @@ -176,7 +176,7 @@ public function updateGatewayRequest(){
                     $username = Session::get("username");
                     $email = Config::get('pga_config.portal')['admin-emails'];
                     $user_profile = Keycloak::getUserProfile($username);
    -                EmailUtilities::mailToUser($user_profile["firstname"], $user_profile["lastname"],
$email, Input::get("gateway_id"));
    +                EmailUtilities::mailToUser($user_profile["firstname"], $user_profile["lastname"],
$user_profile["email"], Input::get("gateway_id"));
    --- End diff --
    
    This code is called when the admin updates the gateway request, right? If so, this will
send an email to the admin because it is getting the email address of the admin's (currently
logged in user) user profile.
    
    Instead it should fetch the Gateway and use the emailAddress field there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message