airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2473) When the gateway request status changes it goes to admin email list, not to the gateway provider
Date Tue, 04 Jul 2017 15:40:00 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073838#comment-16073838
] 

ASF GitHub Bot commented on AIRAVATA-2473:
------------------------------------------

Github user machristie commented on a diff in the pull request:

    https://github.com/apache/airavata-php-gateway/pull/61#discussion_r125499238
  
    --- Diff: app/controllers/AdminController.php ---
    @@ -176,7 +176,7 @@ public function updateGatewayRequest(){
                     $username = Session::get("username");
                     $email = Config::get('pga_config.portal')['admin-emails'];
                     $user_profile = Keycloak::getUserProfile($username);
    -                EmailUtilities::mailToUser($user_profile["firstname"], $user_profile["lastname"],
$email, Input::get("gateway_id"));
    +                EmailUtilities::mailToUser($user_profile["firstname"], $user_profile["lastname"],
$user_profile["email"], Input::get("gateway_id"));
    --- End diff --
    
    This code is called when the admin updates the gateway request, right? If so, this will
send an email to the admin because it is getting the email address of the admin's (currently
logged in user) user profile.
    
    Instead it should fetch the Gateway and use the emailAddress field there.


> When the gateway request status changes it goes to admin email list, not to the gateway
provider
> ------------------------------------------------------------------------------------------------
>
>                 Key: AIRAVATA-2473
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2473
>             Project: Airavata
>          Issue Type: Bug
>          Components: PGA PHP Web Gateway
>    Affects Versions: 0.17
>         Environment: https://dev.scigap.org
>            Reporter: Eroma
>            Assignee: Sneha Tilak
>             Fix For: 0.18
>
>
> Similar to email confirmation this email should only go to the gateway provider. Currently
its going to the admin email notification group list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message