airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machristie <...@git.apache.org>
Subject [GitHub] airavata-php-gateway pull request #70: [AIRAVATA-2521] Ability define gatewa...
Date Mon, 02 Oct 2017 13:38:07 GMT
Github user machristie commented on a diff in the pull request:

    https://github.com/apache/airavata-php-gateway/pull/70#discussion_r142136729
  
    --- Diff: app/controllers/ExperimentController.php ---
    @@ -94,7 +93,17 @@ public function createSubmit()
     
             } else if (isset($_POST['save']) || isset($_POST['launch'])) {
                 try {
    -                $expId = ExperimentUtilities::create_experiment();
    +                $computeResourceId = Input::get("crId");
    +                //Validate entered queue details
    +                $queueValues = array("queueName" => Input::get("queue-name"),
    +                    "nodeCount" => Input::get("nodeCount"),
    --- End diff --
    
    I'm pretty sure these aren't the right names for the form fields. Should be `node-count`,
`cpu-count` and `walltime-count`. See [experiment-queue-block.blade.php](https://github.com/apache/airavata-php-gateway/blob/develop/app/views/partials/experiment-queue-block.blade.php#L80-L98)


---

Mime
View raw message