airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machristie <...@git.apache.org>
Subject [GitHub] airavata-php-gateway pull request #70: [AIRAVATA-2521] Ability define gatewa...
Date Mon, 02 Oct 2017 13:38:07 GMT
Github user machristie commented on a diff in the pull request:

    https://github.com/apache/airavata-php-gateway/pull/70#discussion_r142138406
  
    --- Diff: app/controllers/ExperimentController.php ---
    @@ -396,7 +405,17 @@ public function editSubmit()
         {
             $experiment = ExperimentUtilities::get_experiment(Input::get('expId')); // update
local experiment variable
             try {
    -            $updatedExperiment = ExperimentUtilities::apply_changes_to_experiment($experiment,
Input::all());
    +            $computeResourceId = Input::get("crId");
    +            //Validate entered queue details
    +            $queueValues = array("queueName" => Input::get("queue-name"),
    +                "nodeCount" => Input::get("nodeCount"),
    +                "cpuCount" => Input::get("cpuCount"),
    +                "wallTimeLimit" => Input::get("wallTimeLimit")
    +            );
    +            if($this->validateQueueData($computeResourceId, $queueValues))
    +                $updatedExperiment = ExperimentUtilities::apply_changes_to_experiment($experiment,
Input::all());
    +            else
    +                Redirect::to("experiment/create")->with("error-message", "Validate
the number of nodes, CPUs and the wall time limit");
    --- End diff --
    
    This should redirect to `"experiment/edit"`, not create.


---

Mime
View raw message