airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From machristie <...@git.apache.org>
Subject [GitHub] airavata-php-gateway pull request #70: [AIRAVATA-2521] Ability define gatewa...
Date Mon, 02 Oct 2017 13:38:07 GMT
Github user machristie commented on a diff in the pull request:

    https://github.com/apache/airavata-php-gateway/pull/70#discussion_r142138718
  
    --- Diff: app/controllers/ExperimentController.php ---
    @@ -590,6 +609,21 @@ private function getAllowedFileSize()
             }
             return $allowedFileSize;
         }
    +
    +    private function validateQueueData($computeResourceId, $queue)
    +    {
    +        $queues = ExperimentUtilities::getQueueDatafromResourceId($computeResourceId);
    +        $queueName = $queue['queueName'];
    +
    +        foreach($queues as $aQueue){
    +            if($aQueue->queueName == $queueName) {
    +                if($queue['validateQueueData'] <= $aQueue->maxNodes &&
$queue['maxCPUCount'] <= $aQueue->maxProcessors && $queue['wallTimeLimit'] <=
$aQueue->maxRunTime)
    --- End diff --
    
    The array keys don't match. Should be `nodeCount` instead of `validateQueueData`, and
`cpuCount` instead of `maxCPUCount`.


---

Mime
View raw message