airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2279) Gateway credential store UI also to have the same format as individual user settings
Date Fri, 03 Nov 2017 21:37:00 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238432#comment-16238432
] 

ASF GitHub Bot commented on AIRAVATA-2279:
------------------------------------------

stephenpaul2727 commented on a change in pull request #75: [AIRAVATA-2279 & 2280] FIXED.
URL: https://github.com/apache/airavata-php-gateway/pull/75#discussion_r148898495
 
 

 ##########
 File path: app/controllers/AdminController.php
 ##########
 @@ -345,9 +345,22 @@ public function deleteRole(){
 
 	public function credentialStoreView(){
         Session::put("admin-nav", "credential-store");
-        $tokens = AdminUtilities::get_all_ssh_tokens();
+        $tokens = AdminUtilities::get_all_ssh_tokens_with_description();
+        //Auto-generating the Default SSH Key if there is no key with such description.
 
 Review comment:
   Hi Marcus,
   
   The reason why I'm doing this is if this code is pushed live, most of the people might
not have key with description "default SSH Key". As this key is supposed to be default, I'm
creating one for them. If a default key is not necessary, I'll remove this!
   
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Gateway credential store UI also to have the same format as individual user settings
> ------------------------------------------------------------------------------------
>
>                 Key: AIRAVATA-2279
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2279
>             Project: Airavata
>          Issue Type: Bug
>          Components: PGA PHP Web Gateway
>         Environment: dev.seagrid.org
>            Reporter: Eroma
>            Assignee: Marcus Christie
>            Priority: Major
>             Fix For: 0.18
>
>
> Currently there are no description ora copy button to copy the public key in gateway
credential store.
> Unifying the UI with User settings will make it easy for the gateway admins.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message