airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (AIRAVATA-2509) Account confirmation, password reset emails not making it to user
Date Mon, 20 Nov 2017 21:49:00 GMT


ASF GitHub Bot commented on AIRAVATA-2509:

machristie commented on a change in pull request #79: [AIRAVATA-2509] Account confirmation,
password reset emails not making it to user

 File path: app/controllers/AccountController.php
 @@ -52,7 +53,7 @@ public function createAccountSubmit()
         if (Keycloak::usernameExists($username)) {
             return Redirect::to("create")
-                ->withInput(Input::except('password', 'password_confirm'))
+                ->withInput(Input::except('password', 'confirm_password', 'email', 'confirm_email'))
 Review comment:
   @neeraj-lad we can go ahead and return the form with the email and confirm_email fields.
At this point they have been validated and no point making the user enter them again.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Account confirmation, password reset emails not making it to user
> -----------------------------------------------------------------
>                 Key: AIRAVATA-2509
>                 URL:
>             Project: Airavata
>          Issue Type: Bug
>          Components: PGA PHP Web Gateway
>            Reporter: Marcus Christie
>            Assignee: Neeraj Lad
>            Priority: Critical
>              Labels: newbie
> Email confirmation emails (when creating an account) and password reset emails aren't
always making it to users.  There are at least a couple reasons for this:
> * the emails are getting flagged as spam and the user doesn't check the spam folder
> ** perhaps in some cases the emails never ever reach the user if they are marked as spam
and stopped at the email server
> * the user mis-types their email address
> Possible fixes:
> * Can we find out what is causing emails to be flagged as spam? Is there a way to make
the emails seem less "spammy"?
> ** See for example
> * Require that users type in their email address twice in order to confirm it. This should
help prevent typos.
> * Can we determine if an email bounces back? This might be tricky since I think email
bounce backs are asynchronous.  Perhaps having the user confirm their email address is the
best we can do.
> Workarounds:
> * use CILogon instead of account creation/password reset.

This message was sent by Atlassian JIRA

View raw message