airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2591) Add group roles capabilities to Groups
Date Tue, 28 Nov 2017 21:57:01 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269529#comment-16269529
] 

ASF GitHub Bot commented on AIRAVATA-2591:
------------------------------------------

smarru commented on a change in pull request #141: [AIRAVATA-2591]: Add group roles capabilities
to Groups
URL: https://github.com/apache/airavata/pull/141#discussion_r153635366
 
 

 ##########
 File path: modules/sharing-registry/sharing-registry-server/src/main/resources/sharing-registry-mysql.sql
 ##########
 @@ -56,6 +56,21 @@ CREATE TABLE USER_GROUP (
   FOREIGN KEY (OWNER_ID, DOMAIN_ID) REFERENCES SHARING_USER(USER_ID, DOMAIN_ID) ON DELETE
CASCADE ON UPDATE NO ACTION
 )ENGINE=InnoDB DEFAULT CHARACTER SET=latin1;
 
+CREATE TABLE GROUP_OWNER (
+  OWNER_ID VARCHAR(255) NOT NULL,
+  GROUP_ID VARCHAR(255) NOT NULL,
+  DOMAIN_ID VARCHAR(255) NOT NULL,
+  PRIMARY KEY (OWNER_ID, DOMAIN_ID),
 
 Review comment:
   @sachinkariyattin i merged this PR before I reviewed @machristie comment above. After reviewing
it back again, I fully agree with this above comments. Since groups can have multiple admins,
it makes sense to have a GROUP_ADMIN table. But since groups can only have one owner, it makes
sense to get rid of GROUP_OWNER table and use the OWNER_ID in the USER_GROUP table. Can you
please make changes accordingly? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add group roles capabilities to Groups 
> ---------------------------------------
>
>                 Key: AIRAVATA-2591
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2591
>             Project: Airavata
>          Issue Type: New Feature
>            Reporter: Suresh Marru
>            Assignee: Sachin Kariyattin
>
> Currently, the group members do not have fine-grained roles so only the owner can add
users to this group. 
> It will be better to add group-member-roles:
> * The owner who creates the group initially. This ownership should be transferable to
a different user. Only owners should be allowed to delete the groups. 
> * admin - a user role which will allow to add more users or remove users from the group.

> * user - all users added to the group are by default in this role. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message