airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2619) Refactoring App Catalog implementation
Date Thu, 12 Apr 2018 05:37:00 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434972#comment-16434972
] 

ASF GitHub Bot commented on AIRAVATA-2619:
------------------------------------------

sachinkariyattin commented on a change in pull request #182: [AIRAVATA-2619] Refactoring App
Catalog implementation - StorageResource
URL: https://github.com/apache/airavata/pull/182#discussion_r180969151
 
 

 ##########
 File path: modules/registry/registry-server/registry-api-service/src/main/java/org/apache/airavata/registry/api/service/handler/RegistryServerHandler.java
 ##########
 @@ -1626,8 +1627,7 @@ public boolean deleteComputeResource(String computeResourceId) throws
RegistrySe
     @Override
     public StorageResourceDescription getStorageResource(String storageResourceId) throws
RegistryServiceException, TException {
         try {
-            appCatalog = RegistryFactory.getAppCatalog();
-            StorageResourceDescription storageResource = appCatalog.getStorageResource().getStorageResource(storageResourceId);
+            StorageResourceDescription storageResource = new StorageResourceRepository().getStorageResource(storageResourceId);
 
 Review comment:
   Done!. I have to do this for other repository classes as well (GatewayRepository, ComputeRepository
etc.)
   
   I will make these changes in another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactoring App Catalog implementation
> --------------------------------------
>
>                 Key: AIRAVATA-2619
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2619
>             Project: Airavata
>          Issue Type: Sub-task
>            Reporter: Sachin Kariyattin
>            Assignee: Sachin Kariyattin
>            Priority: Major
>
> The app catalog module contains the following Impl classes.
> {quote}ApplicationDeploymentImpl
>  ApplicationInterfaceImpl
>  ComputeResourceImpl
>  GwyResourceProfileImpl
>  StorageResourceImpl
>  UsrResourceProfileImpl
> {quote}
> This task involves creating a repository class for app catalog and include all the methods
from the Impl classes mentioned above. As a modular approach is being followed, to start of,
only methods GwyResourceProfileImpl will be considered. So the RegistryServiceHandler methods
only with respect to GwyResourceProfileImpl will be modified. Subsequently all methods related
to app catalog will be refactored.
> *Progress*:
>  * Implemeted GatewayResourceProfileRepository.
>  * Implemented ComputeResourceRepository.
>  * Implemented StorageResourceRepository.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message