airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2728) Refactoring Experiment Catalog Implementation
Date Fri, 27 Apr 2018 13:56:00 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456475#comment-16456475
] 

ASF GitHub Bot commented on AIRAVATA-2728:
------------------------------------------

machristie commented on a change in pull request #191: [AIRAVATA-2728] Refactoring Experiment
Catalog Implementation
URL: https://github.com/apache/airavata/pull/191#discussion_r184692645
 
 

 ##########
 File path: modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/entities/expcatalog/ComputeResourceScheduleEntity.java
 ##########
 @@ -17,31 +17,70 @@
  * specific language governing permissions and limitations
  * under the License.
  *
-*/
+*//*
+
 package org.apache.airavata.registry.core.entities.expcatalog;
 
 import javax.persistence.*;
+import java.io.Serializable;
+
+*/
+/**
+ * The persistent class for the compute_resource_schedule database table.
+ *//*
 
 @Entity
-@Table(name = "EXPCAT_COMPUTE_RESOURCE_SCHEDULING")
-public class ComputeResourceSchedulingEntity {
+@Table(name = "COMPUTE_RESOURCE_SCHEDULE")
 
 Review comment:
   This table is called USER_CONFIGURATION_DATA, not COMPUTE_RESOURCE_SCHEDULE.  See https://github.com/apache/airavata/blob/develop/modules/registry/registry-core/src/main/resources/expcatalog-mysql.sql#L178.
   
   I'm afraid that wherever these EXPCAT_* tables came from are very outdated. You should
use expcatalog-mysql.sql from registry-core as the source of truth about what these tables
should look like.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactoring Experiment Catalog Implementation
> ---------------------------------------------
>
>                 Key: AIRAVATA-2728
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2728
>             Project: Airavata
>          Issue Type: Improvement
>          Components: Registry API
>            Reporter: Sneha Tilak
>            Assignee: Sneha Tilak
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message