airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2728) Refactoring Experiment Catalog Implementation
Date Tue, 17 Apr 2018 17:57:00 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441261#comment-16441261
] 

ASF GitHub Bot commented on AIRAVATA-2728:
------------------------------------------

machristie commented on a change in pull request #191: [AIRAVATA-2728] Refactoring Experiment
Catalog Implementation
URL: https://github.com/apache/airavata/pull/191#discussion_r182172558
 
 

 ##########
 File path: modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/repositories/expcatalog/ProjectRepository.java
 ##########
 @@ -159,9 +157,13 @@ else if (field.equals(DBConstants.Project.DESCRIPTION)) {
 
         }
 
-        if (!accessibleProjectIds.isEmpty() && accessibleProjectIds != null) {
+        if (accessibleProjectIds != null && !accessibleProjectIds.isEmpty()) {
             logger.debug("Filter Projects by Accessible Project IDs");
-            query += " P.projectId IN :" + accessibleProjectIds;
+            query += "P.projectId IN (";
 
 Review comment:
   @tilaks26 The error is because there are these hyphens in the query variable name (`:projectName_a7220549-302a-40c5-886c-8515a0306b90`).
 But the problem is that it looks like you are putting the values into the query directly
when you should be putting variables into the query and putting the values into a map. You
would add something like `"P.projectID IN (:" + DBConstants.Project.PROJECT_ID + ")"` to the
query and then put (PROJECT_ID, accessibleProjectIds) into a `queryParams` map, then call
the `select(query, limit, offset, queryParams)` repository method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactoring Experiment Catalog Implementation
> ---------------------------------------------
>
>                 Key: AIRAVATA-2728
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2728
>             Project: Airavata
>          Issue Type: Improvement
>          Components: Registry API
>            Reporter: Sneha Tilak
>            Assignee: Sneha Tilak
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message