allura-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kentontay...@apache.org
Subject [allura] 05/18: [#8320] Upgrade pyflakes
Date Mon, 05 Aug 2019 18:27:33 GMT
This is an automated email from the ASF dual-hosted git repository.

kentontaylor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/allura.git

commit 40d9b821a9600f3a2405782b0a243878f7c01d22
Author: Dave Brondsema <dave@brondsema.net>
AuthorDate: Fri Jul 19 18:14:51 2019 -0400

    [#8320] Upgrade pyflakes
---
 Allura/allura/model/artifact.py                | 2 +-
 Allura/allura/tests/model/test_notification.py | 6 +++---
 Allura/allura/tests/test_plugin.py             | 2 +-
 requirements-dev.txt                           | 2 +-
 requirements.in                                | 2 +-
 requirements.txt                               | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Allura/allura/model/artifact.py b/Allura/allura/model/artifact.py
index 4df6cd3..873b9e5 100644
--- a/Allura/allura/model/artifact.py
+++ b/Allura/allura/model/artifact.py
@@ -528,7 +528,7 @@ class Snapshot(Artifact):
         return result
 
     def original(self):
-        raise NotImplemented('original')  # pragma no cover
+        raise NotImplementedError('original')  # pragma no cover
 
     def shorthand_id(self):
         return '%s#%s' % (self.original().shorthand_id(), self.version)
diff --git a/Allura/allura/tests/model/test_notification.py b/Allura/allura/tests/model/test_notification.py
index 91f88d4..57eefd2 100644
--- a/Allura/allura/tests/model/test_notification.py
+++ b/Allura/allura/tests/model/test_notification.py
@@ -501,9 +501,9 @@ class TestSiteNotification(unittest.TestCase):
 
     def test_json_values_if_missing(self):
         note_json = self.note.__json__()
-        assert note_json['page_regex'] is ''
-        assert note_json['page_tool_type'] is ''
-        assert note_json['user_role'] is ''
+        assert note_json['page_regex'] == ''
+        assert note_json['page_tool_type'] == ''
+        assert note_json['user_role'] == ''
 
 
 def _clear_subscriptions():
diff --git a/Allura/allura/tests/test_plugin.py b/Allura/allura/tests/test_plugin.py
index f02f731..b153977 100644
--- a/Allura/allura/tests/test_plugin.py
+++ b/Allura/allura/tests/test_plugin.py
@@ -512,7 +512,7 @@ class TestThemeProvider(object):
         get_note = ThemeProvider()._get_site_notification()
 
         assert isinstance(get_note, tuple)
-        assert len(get_note) is 2
+        assert len(get_note) == 2
         assert get_note[0] is note
         assert get_note[1] == 'test_id-1-False'
 
diff --git a/requirements-dev.txt b/requirements-dev.txt
index a8ad534..54109cd 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -65,7 +65,7 @@ pillow==5.2.0
 pip-tools==3.8.0
 poster==0.8.1
 pycparser==2.19           # via cffi
-pyflakes==0.8.1
+pyflakes==2.1.1
 pygments==2.2.0
 pylint==1.9.5
 pymongo==2.8.1
diff --git a/requirements.in b/requirements.in
index 53c34e3..84a2be1 100644
--- a/requirements.in
+++ b/requirements.in
@@ -50,7 +50,7 @@ ipython==1.2.1
 mock==1.0.1
 nose==1.3.4
 poster==0.8.1
-pyflakes==0.8.1
+pyflakes
 pylint
 testfixtures==3.0.0
 WebTest==2.0.33
diff --git a/requirements.txt b/requirements.txt
index 439028d..a2a7983 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -59,7 +59,7 @@ pastescript==2.0.2
 pillow==5.2.0
 poster==0.8.1
 pycparser==2.19           # via cffi
-pyflakes==0.8.1
+pyflakes==2.1.1
 pygments==2.2.0
 pylint==1.9.5
 pymongo==2.8.1


Mime
View raw message