> On June 30, 2014, 3:52 p.m., Tom Beerbower wrote:
> > Is it possible to write a unit test to reproduce the issue you are trying to solve
and then so that the patch fixes the issue?
Added unit tests for 2 cases:
1. page_request + resources properties in predicate.
2. page_request + sub-resources properties in predicate(fails before this patch)
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23170/#review46984
-----------------------------------------------------------
On July 1, 2014, 10:50 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23170/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 10:50 a.m.)
>
>
> Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.
>
>
> Bugs: AMBARI-6317
> https://issues.apache.org/jira/browse/AMBARI-6317
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Selected filter on components on Hosts page to filter by 'Namenode'. No hosts were selected.
> All parent-resources have to be populated if there is sub-resource in predicate.
>
> Before patch getPage() were called for hosts requests even if host_components/../...
in predicate
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java a607761
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java ad453d9
>
> Diff: https://reviews.apache.org/r/23170/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.157s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [26.103s]
> [INFO] Ambari Views ...................................... SUCCESS [1.794s]
> [INFO] Ambari Server ..................................... SUCCESS [14:59.062s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.913s]
> [INFO] Ambari Client ..................................... SUCCESS [0.029s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.100s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.434s]
> [INFO] Ambari Shell ...................................... SUCCESS [6.173s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
|