ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 23343: Reimplementation of Maintenance mode support
Date Thu, 10 Jul 2014 13:41:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23343/
-----------------------------------------------------------

(Updated July 10, 2014, 1:41 p.m.)


Review request for Ambari, Mahadev Konar, Sid Wagle, and Vitalyi Brodetskyi.


Changes
-------

Fixed


Bugs: AMBARI-6423
    https://issues.apache.org/jira/browse/AMBARI-6423


Repository: ambari


Description
-------

Changes are basically tested, but lack full UI support. It was agreed with Mahadev to commit
MM as is and then perform full-pledged end2end testing when UI support is fully implemented.
That is tracked by a separate jira.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
375794d 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 959ee5a

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
c66d2e2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
403d6a2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
abd1238 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
5fa95fb 
  ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
191c647 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
c1ddcd3 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java
a74b8a1 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
18f9d6b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
d1c18c5 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
8d518e4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
3efceed 
  ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java
08ccc87 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java
588932a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
b3f40a5 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
c3e5a95 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
bff767e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java
d832015 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
f4bfef2 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
4f6c0c0 

Diff: https://reviews.apache.org/r/23343/diff/


Testing
-------

Failed tests:   testPopulateServicesForStack(org.apache.ambari.server.api.util.StackExtensionHelperTest):
expected:<38> but was:<37>
  testUpgrade(org.apache.ambari.server.upgrade.UpgradeTest): Upgrade test failed for version:
[1.4.4, 1.4.3, 1.4.2, 1.4.1, 1.4.0, 1.2.5, 1.2.4, 1.2.3]

Tests run: 1736, Failures: 2, Errors: 0, Skipped: 13

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.343s]
[INFO] Ambari Server ..................................... FAILURE [13:29.256s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------


2 tests are failing on trunk. There is a pending jira AMBARI-6422 (that is under review) 
to fix them.


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message