ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions
Date Mon, 21 Jul 2014 15:04:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48230
-----------------------------------------------------------


Why isn't any of this returned with HostInfo and use that information straight out of Ambari?
 Why add all this extra work on the agent to get the disk usage info when it should be part
of HostInfo.

- Nate Cole


On July 18, 2014, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 2:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling
disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari
should watch for all these locations and warn when they fill up beyond a threshold like 80%
(configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947

>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252

>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd

>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java
7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java
cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message