From dev-return-61295-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org Mon Mar 2 15:38:59 2015 Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C852176C2 for ; Mon, 2 Mar 2015 15:38:59 +0000 (UTC) Received: (qmail 93752 invoked by uid 500); 2 Mar 2015 15:38:53 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 93717 invoked by uid 500); 2 Mar 2015 15:38:53 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 93700 invoked by uid 99); 2 Mar 2015 15:38:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 15:38:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5139B1C0D6B; Mon, 2 Mar 2015 15:38:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5029210999630093687==" MIME-Version: 1.0 Subject: Re: Review Request 31624: SECONDARY_NAMENODE persist object in memory, causes HostVersion to stay in UPGRADING From: "Tom Beerbower" To: "Alejandro Fernandez" , "Nate Cole" , "Jonathan Hurley" Cc: "Ambari" , "Tom Beerbower" Date: Mon, 02 Mar 2015 15:38:52 -0000 Message-ID: <20150302153852.12263.14309@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/31624/ X-Sender: "Tom Beerbower" References: <20150302145432.12262.99504@reviews.apache.org> In-Reply-To: <20150302145432.12262.99504@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============5029210999630093687== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31624/ ----------------------------------------------------------- (Updated March 2, 2015, 3:38 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole. Bugs: AMBARI-9869 https://issues.apache.org/jira/browse/AMBARI-9869 Repository: ambari Description ------- Finalize fails because one of the hosts (always the one that had the secondary namenode before) still has a host_version with a state of UPGRADING and doesn't transition it to UPGRADED. When the SECONDARY_NAMENODE is deleted via the Namenode HA wizard, the HostEntity may still retain a reference to it, thereby causing the object to remain in memory. For some reason the bi-directional relationships between the host entity and the state entities are not cleaned up on the host side by JPA. The patch uses a brute force approach to remove the state entites from the collections held by the host entity. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java 9635f30 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java 66e91d3 ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java fe5397b Diff: https://reviews.apache.org/r/31624/diff/ Testing (updated) ------- Manual testing to verify that the HostEntity references to the state entities are cleaned up. All existing tests pass ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 33:16 min [INFO] Finished at: 2015-03-02T10:37:09-05:00 [INFO] Final Memory: 42M/568M [INFO] ------------------------------------------------------------------------ Thanks, Tom Beerbower --===============5029210999630093687==--