ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 38312: Upgrade Packs Should Define Skippable Failed Slave/Clients
Date Fri, 11 Sep 2015 20:36:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38312/#review98683
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Sept. 11, 2015, 6:43 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38312/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 6:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-13078
>     https://issues.apache.org/jira/browse/AMBARI-13078
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Although the upgrade endpoint can be used to marked failures as being automatically skipped:
> 
> {code:title=POST api/v1/clusters/c1/upgrades}
> {
>   "Upgrade": {
>     "repository_version": "2.3.0.0-2545",
>     "skip_failures": true
>   }
> }
> {code}
> 
> The upgrade packs should also allow this behavior by default:
> 
> {code}
>   <skip-failures>false</skip-failures>
>   <skip-service-check-failures>false</skip-service-check-failures>
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
d087945 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeGroupEntity.java
7b57184 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 9691292

>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml d67671c 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 04befaf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 4719558 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
7d2c117 
>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
e073b43 
>   ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_skip_failures.xml
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38312/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message