ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ambari] dlysnichenko commented on a change in pull request #3225: AMBARI-25549 NegativeArraySizeException thrown when invoking CurrentCollectorHost
Date Wed, 09 Sep 2020 18:40:43 GMT

dlysnichenko commented on a change in pull request #3225:
URL: https://github.com/apache/ambari/pull/3225#discussion_r485833242



##########
File path: ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
##########
@@ -148,6 +150,20 @@
       .withSerializationInclusion(JsonSerialize.Inclusion.NON_NULL);
   }
 
+  private final class CollectorShardSupplier implements Supplier<String> {
+    @Override
+    public String get() {
+      //shardExpired flag is used to determine if the Supplier.get() is invoked through the
+      // findPreferredCollectHost method (No need to refresh collector hosts

Review comment:
       ```suggestion
         // findPreferredCollectHost method (No need to refresh collector hosts)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message