apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49847] apr_pcalloc should assert that memory is allocated
Date Wed, 01 Sep 2010 03:22:55 GMT

--- Comment #6 from dave b <db.pub.mail@gmail.com> 2010-08-31 23:22:53 EDT ---
(In reply to comment #5)
> >I don't think this changes the fact that there is a large
> number of mod_'s that are using these methods without checking it is null
> first.
> If you're talking about mod_'s for Apache httpd, note that it doesn't check
> apr_palloc/pcalloc retcodes either before trying to use the pointers.

Yeah I know ... why is that? 

> I'm marking this INVALID.  APR's API doesn't allow this to blow
> up/assert/whatever unless the app uses the existing APR mechanism to handle
> palloc/pcalloc failures under the covers: the abort function.  That is a
> sufficient level of function AFAICT.
> You'll have to lobby with your favorite apps to get them to figure out how to
> use the abort function in a way that handles failures much better than at
> present, without writing boatloads of code that almost never runs.

Fair enough. :)

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

View raw message