archive-license mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Crossley <cross...@apache.org>
Subject Re: Review of proposed Apache License, version 2.0
Date Wed, 21 Jan 2004 01:11:57 GMT
Roy T. Fielding wrote:
> > I would like to support all this. Whitespace is not a minor issue.
> > Inconsistencies wreak havoc on CVS diffs. It seems that some
> > text editors try to correct these inconsistencies (e.g. to change
> > any 3-space indentation back to 2-space indentation) which results
> > in an unnecessary and confusing diff.
> >
> > * The main license has 2-space indentation which is great. However
> > some lines have an odd number of spaces, e.g. the first line here
> > incorrectly has 3 spaces while the second line correctly has 6 spaces.
> 
> The entire license has 3-space indentation, except where indentation
> is being used to show hierarchy.  My editor does not suffer from the
> problem you describe and I do not expect anyone else to be editing
> the license text (at least not with a broken editor).

The reason for my comments about inconsistent whitespace is that
we have seen big troubles in CVS with the license header at the
top of *.java files etc. Some people have text editors that have
capabilities to automatically "correct" whitespace and this causes
mangled diffs.

--David



Mime
View raw message