aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Osborne (JIRA)" <j...@apache.org>
Subject [jira] Created: (ARIES-48) BeanRecipe has two destroy methods, the one that invokes BeanProcessor is unused.
Date Tue, 10 Nov 2009 15:55:28 GMT
BeanRecipe has two destroy methods, the one that invokes BeanProcessor is unused.
---------------------------------------------------------------------------------

                 Key: ARIES-48
                 URL: https://issues.apache.org/jira/browse/ARIES-48
             Project: Aries
          Issue Type: Bug
          Components: Blueprint
            Reporter: Andrew Osborne


BeanRecipe declares 
  destroy(Object instance) which invokes the destroy method if any.. 
and
  destroyInstance(Object obj) which does the same, but also invokes the BeanProcessor before/after
destroy calls. 

destroyInstance has no callers within the codebase, without which the BeanProcessor will never
be invoked for before/after destroy.

SVN history has the destroyInstance method present as far back as I can check for, with the
seperate destroy method being brought in as part of the Recipe refactoring that removed DestroyCallback,
although DestroyCallback did not invoke destroyInstance either.

Suspect the fix to this is to remove destroy(Object instance) and rename destroyInstance(Object
obj) to destroy(Object obj)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message