aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lin Sun <linsun....@gmail.com>
Subject Re: svn commit: r960866 - in /incubator/aries/trunk/application: application-api/ application-management/ application-management/src/main/java/org/apache/aries/application/management/impl/ application-management/src/test/java/org/apache/aries/applica
Date Wed, 07 Jul 2010 13:14:37 GMT
+1 on Alasdair's note below.

Thank you both!

Lin

On Wed, Jul 7, 2010 at 8:57 AM, Emily Jiang <EMIJIANG@uk.ibm.com> wrote:
> Thanks Alasdair,
>
> I like your suggestion. I will raise a jira and get it fixed.
>
> Many thanks and kindest regards,
> Emily
> ===========================
> Emily Jiang
> WebSphere ESB Foundation Technologies
>
> MP 211, DE3A25, Winchester, Hampshire, England, SO21 2JN
> Phone:  +44 (0)1962 816278  Internal: 246278
>
> Email: emijiang@uk.ibm.com
> Lotus Notes: Emily Jiang/UK/IBM@IBMGB
>
>
>
>
> From:   Alasdair Nottingham <not@apache.org>
> To:     "aries-dev@incubator.apache.org" <aries-dev@incubator.apache.org>
> Date:   07/07/2010 13:20
> Subject:        Re: svn commit: r960866 - in
> /incubator/aries/trunk/application: application-api/
> application-management/
> application-management/src/main/java/org/apache/aries/application/management/impl/
> application-management/src/test/java/org/apache/aries/applica
> Sent by:        Alasdair Nottingham <alasdair.nottingham@gmail.com>
>
>
>
> Hi,
>
> That would be a change in behaviour, I'm not sure it is a major one
> though. Removing the if test though wont have the effect you describe
> though. First we will do conversion when there is a deployment.mf, which
> we don't do right now, and second there is no cross validation code, and
> I'm not sure there should be.
>
> So if you go down this route I would suggest you move the load of the
> deployment.mf to occur prior to the bundle conversion and change the if
> clause to ensure that the conversion logic is only called if the
> deployment.mf does not exist and don't raise the exception.
>
> Quick disclaimer I'm on holiday and am just going by the diff attached.
>
> Alasdair Nottingham
>

Mime
View raw message