aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremy Hughes <jpjhug...@gmail.com>
Subject Re: Accepting pull requests for Aries from Github
Date Fri, 28 Mar 2014 12:12:37 GMT
There's a long discussion on the members@ list.

https://mail-search.apache.org/members/private-arch/members/201311.mbox/%3C9CC82400-9A4B-4DE3-A502-C18A7C6A3179@gmail.com%3E

(sorry that's a private list).

This summarises it:

https://issues.apache.org/jira/browse/LEGAL-156

Cheers,
Jeremy

On 28 March 2014 08:35, <davidb@apache.org> wrote:

> That's great - but I'm wondering how this works from an IP-flow point of
> view.
> I guess that by attaching a patch to a JIRA issue one formally donates
> the code to Apache.
>
> But by merging a github pull request you take a few commits from
> someone's own fork and add this to the main repo. I guess you could
> view the creation of the pull request itself as a statement by the
> committer that (s)he wants to donate this code?
>
> Anyway - do you know of a formal document somewhere where interaction
> with github (or other code repos) is defined?
>
> Cheers,
>
> David
>
> On 27 March 2014 19:31, Daniel Kulp <dkulp@apache.org> wrote:
> >
> > On Mar 27, 2014, at 8:05 AM, davidb@apache.org wrote:
> >
> >> Hi all,
> >>
> >> I noticed that there are a few pull requests on Aries at github [1].
> >> I was wondering, can we just apply these, or must they be physically
> >> attached to JIRA issues to correctly follow IP rules?
> >> I noticed that e.g. [2] does mention the pull request in the comments...
> >>
> >> Just wondering what the process should be...
> >
> > Pulling the pull requests directly is fine.  Many projects have started
> preferring that.
> >
> > When you do, it's sometimes best to amend/edit the commit log to include
> something like
> >
> > "This closes #2"
> >
> > so the pull request will close automatically when you commit.
> >
> > Dan
> >
> >
> >>
> >> Cheers,
> >>
> >> David
> >>
> >> [1] https://github.com/apache/aries/pulls
> >> [2] https://issues.apache.org/jira/browse/ARIES-1164
> >
> > --
> > Daniel Kulp
> > dkulp@apache.org - http://dankulp.com/blog
> > Talend Community Coder - http://coders.talend.com
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message