aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Freeman Fang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (ARIES-1186) Upgrade to ASM 5 for Java 8 support
Date Tue, 13 May 2014 03:54:16 GMT

    [ https://issues.apache.org/jira/browse/ARIES-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995995#comment-13995995
] 

Freeman Fang edited comment on ARIES-1186 at 5/13/14 3:53 AM:
--------------------------------------------------------------

Hi  Harald,

Thanks for the patch, seems Karaf|Aries Java8 support become more and more hot now.
Just one question, I saw you have some changes like
{code}
-    super(cv);
+    super(ASM4, cv);
{code}

in your patch, shouldn't it be the Opcodes.ASM5 here as we are upgrading to ASM5,  so that
the ASM api version should be ASM5, right?

If so, there are also several places in proxy-impl module should use Opcodes.ASM5 instead
of Opcodes.ASM4.

Cheers
Freeman


was (Author: ffang):
Hi  Harald,

Thanks for the patch, seems Karaf|Aries Java8 support become more and more hot now.
Just one question, I saw you have some changes like
-    super(cv);
+    super(ASM4, cv);

in your patch, shouldn't it be the Opcodes.ASM5 here as we are upgrading to ASM5,  so that
the ASM api version should be ASM5, right?

If so, there are also several places in proxy-impl module should use Opcodes.ASM5 instead
of Opcodes.ASM4.

Cheers
Freeman

> Upgrade to ASM 5 for Java 8 support
> -----------------------------------
>
>                 Key: ARIES-1186
>                 URL: https://issues.apache.org/jira/browse/ARIES-1186
>             Project: Aries
>          Issue Type: Improvement
>          Components: Proxy
>    Affects Versions: proxy-impl-1.0.2
>            Reporter: Harald Wellmann
>            Priority: Critical
>
> Aries Proxy does not work under Java 8, since it depends on ASM 4 which does not support
Java 8.
> This is currently a blocker for working with Karaf 3.0.1 under Java 8. (Karaf contains
Aries Proxy Impl 1.0.2).
> Upgrading to ASM 5.0.2 requires changing a few {{super()}} calls in Aries subclasses
of ASM classes.
> I tried a local build of Aries Proxy Impl 1.0.3-SNAPSHOT with these changes, and the
result seems to be ok for Karaf.
> The larger part of the issue on Aries side is the dependency on a prehistoric version
of Pax Exam which depends on Pax Runner (with additional configuration tweaks from Aries)
which does not support Java 8 either, so I haven't been able to run the Proxy integration
tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message