aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samuel Bratton (JIRA)" <>
Subject [jira] [Updated] (ARIES-1283) Subsystem import/export service header parsing is incorrect
Date Wed, 21 Jan 2015 20:08:35 GMT


Samuel Bratton updated ARIES-1283:
    Attachment: ARIES-1283.patch

Attached patch file ARIES-1283.patch to correct issue. Corrected pattern string for matching
inport/export clause. Code was incorrectly using a pattern that matched the entire header
line, causing it to fail with mult clauses. Also removed unused string pattern constants,
and changed the  Manifest for the CompositeServiceTest to contain an input sequence which
would have failed before this patch. This patch applies to trunk and R6 .

> Subsystem import/export service header parsing is incorrect
> -----------------------------------------------------------
>                 Key: ARIES-1283
>                 URL:
>             Project: Aries
>          Issue Type: Bug
>          Components: Subsystem
>         Environment: All
>            Reporter: Thomas Watson
>            Assignee: Thomas Watson
>         Attachments: ARIES-1283.patch
> ARIES-1263 introduced a bug in the parsing of the Subsystem import/export service headers.
 It appears the wildcard matching is causing the regular expressions used to parse the headers
to match too much.  If you modify test file:
> subsystem/subsystem-itests/src/test/resources/composite2/OSGI-INF/SUBSYSTEM.MF
> To have the following the test will fail:
> Subsystem-ExportService: *;filter:="(test=tb4)", does.not.exist; filter:="(a=b)"
> It appears the parsing converts the above to be something like
> Subsystem-ExportService: *;filter:="(a=b)"
> Basically collapsing the elements into one and using the last filter.  This is causing
Subsystem OSGi CT failures.

This message was sent by Atlassian JIRA

View raw message