aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bosschaert <...@git.apache.org>
Subject [GitHub] aries-containers issue #1: Suggesting a different way of writing the Builder
Date Wed, 27 Sep 2017 10:22:28 GMT
Github user bosschaert commented on the issue:

    https://github.com/apache/aries-containers/pull/1
  
    Hi @bdelacretaz thanks for the contribution! Having all member variables as final (as
it was before) is kind of nice because you know that at least for the scalars they will be
immutable. OTOH with your approach the members are private and there are no setters, so they
are effectively immutable (combined with the collection lockdowns). I agree that your approach
is nice in that it avoids the duplication of variables in the builder.
    
    I'd be more than happy to take this in.


---

Mime
View raw message