aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BruceKuiLiu <...@git.apache.org>
Subject [GitHub] aries pull request #78: Add an IfStatement to check the return value of temp...
Date Mon, 09 Oct 2017 20:49:07 GMT
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/aries/pull/78

    Add an IfStatement to check the return value of temp.delete().

    This statement returns a value that is not checked.
    The return value should be checked since it can indicate an unusual or unexpected function
execution.
    The statement returns false if the file could not be successfully deleted (rather than
throwing an Exception).
    If the result was not checked, developers would not notice if the statement signals an
unexpected behavior by returning an atypical return value.
    http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/aries trunk3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #78
    
----
commit 00a84d35614212d016134a3895bf95e5546ea7ed
Author: Kui LIU <brucekuiliu@gmail.com>
Date:   2017-10-09T20:47:36Z

    Add an IfStatement to check the return value of temp.delete().
    
    This statement returns a value that is not checked.
    The return value should be checked since it can indicate an unusual or unexpected function
execution.
    The statement returns false if the file could not be successfully deleted (rather than
throwing an Exception).
    If the result was not checked, developers would not notice if the statement signals an
unexpected behavior by returning an atypical return value.
    http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

----


---

Mime
View raw message