aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BruceKuiLiu <...@git.apache.org>
Subject [GitHub] aries pull request #79: Remove the redundant null check expression of a non-...
Date Mon, 09 Oct 2017 21:27:50 GMT
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/aries/pull/79

    Remove the redundant null check expression of a non-null value this.appVersion

    
    The expression "this.appVersion == null" is a redundant check of a known non-null value
because this.appVersion is created by a constructor method.
    http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/aries trunk4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit 42070c4568ceaa47bc585812ba91000af34d3d90
Author: Kui LIU <brucekuiliu@gmail.com>
Date:   2017-10-09T21:26:06Z

    Remove the redundant null check expression of a non-null value this.appVersion.
    
    The expression "this.appVersion == null" is a redundant check of a known non-null value
because this.appVersion is created by a constructor method.
    http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

----


---

Mime
View raw message