aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgalla <...@git.apache.org>
Subject [GitHub] aries pull request #93: Fixed bug causing array properties to not evaluate a...
Date Wed, 12 Dec 2018 20:23:10 GMT
GitHub user sgalla opened a pull request:

    https://github.com/apache/aries/pull/93

    Fixed bug causing array properties to not evaluate as equal

    When the properties being compared in the equals method are arrays, using .equals may
not evaluate correctly. This PR does a deep equals if the two objects being compared are arrays,
and falls back on .equals if they are not.
    
    This bug was causing infinite reloads when we had arrays in config files because the arrays
never evaluated to equal.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgalla/aries trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #93
    
----
commit b33b63f32c83b8c08651702854baa49fc4cabda9
Author: Shannon Gallagher <shannon.gallagher@...>
Date:   2018-12-12T20:11:59Z

    Fixed bug causing array properties to not evaluate as equal

----


---

Mime
View raw message