arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ravindra Pindikura <ravin...@dremio.com>
Subject Re: CMake refactor Heads-up
Date Sat, 16 Mar 2019 05:33:27 GMT
On Sat, Mar 16, 2019 at 2:38 AM Suvayu Ali <fatkasuvayu+linux@gmail.com>
wrote:

> Hi Uwe,
>
> On Fri, Mar 15, 2019 at 10:38:32AM -0400, Uwe L. Korn wrote:
> >
> > we have merged the CMake refactor yesterday
> https://github.com/apache/arrow/pull/3688 and this means that the build
> system behaves a bit different. The main differences are:
>
> That's a lot of work!  Thank you very much :)  I have some comments below
> on using system libraries.
>
> > * The *_HOME variables are not longer use and are replaced by *_ROOT
> variables to use CMake's standard detection features. Be aware that
> dependencies are no longer written in all caps but their preferred casing
> as seen in
> https://github.com/apache/arrow/blob/0d302125abb4b514dba210f496c574a77ce4cd1d/cpp/cmake_modules/ThirdpartyToolchain.cmake#L41-L59
>
> Is there a recommended way to choose between Python versions?  Fedora
> repos often provide several Python versions, e.g. on F28 I have 2.7
> (default), 3.6, and 3.7.  The correct Python version was detected for me
> with:
>
>   -DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3.6m
>
> Is this fine?  Or should there be an easier way to do this?
>
> Secondly, I was trying to compile with Gandiva enabled.  But it seems the
> LLVM requirement has gone up to 7.0 (available only on F29 onwards).  I had
> managed to compile with 6.0 until 0.12, was that a happy conincidence?
>

We switched to llvm 7.0 about a month back, in the 0.13 timeframe (thanks
to @wesm).


>
> Thanks again for your work.
>
> Cheers,
>
> --
> Suvayu
>
> Open source is the future. It sets us free.
>


-- 
Thanks and regards,
Ravindra.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message