asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Blow <mblow.apa...@gmail.com>
Subject Re: PLEASE READ: Automatic formatting of sources
Date Mon, 29 Jan 2018 03:21:34 GMT
s/ade/git/ in those commands- I suffered a case of Oracle flashback when
writing those out...
On Sun, Jan 28, 2018 at 10:20 PM Michael Blow <mblow.apache@gmail.com>
wrote:

> Hi Steven,
>
> Technically all lines will be processed, however this is effectively only
> edited lines since we have a normalized baseline.
>
> On Sun, Jan 28, 2018 at 6:01 PM Steven Jacobs <sjaco002@ucr.edu> wrote:
>
>> Just curious, is it going to format everything (as in, your change cleaned
>> up the entire code base) or just the edited lines only?
>> Steven
>>
>> On Sun, Jan 28, 2018 at 1:01 PM Michael Blow <mblow.apache@gmail.com>
>> wrote:
>>
>> > All,
>> >
>> > As mentioned in last week's status meeting, I have submitted a change
>> which
>> > applies and enforces our code format[1] at build / jenkins time.  As of
>> > this commit, source formatting happens as part of the 'process-sources'
>> > build phase.  This can be run explicitly (to format your code prior to
>> > commit) but is already run prior to the compile phase, so if you are
>> > building with maven, it will be run for you.
>> >
>> > Jenkins will be enforcing that patches moving forward comply with the
>> > template [2].  If your patch fails this job, ensure you run 'mvn
>> > process-sources' and resubmit the result.
>> >
>> > To migrate outstanding topic branches, it is recommended to do the
>> > following steps to minimize conflict resolution:
>> >
>> > *ade merge cb9ca97531eddee2cd312654bf13b0905cb3ef6e~1 *
>> > *mvn process-sources -Psource-format -Drat.skip*
>> > *ade commit -a*
>> > *ade merge cb9ca97531eddee2cd312654bf13b0905cb3ef6e*
>> > *ade commit -a*
>> >
>> > Let me know if you run into any issues,
>> >
>> > Thanks,
>> >
>> > -MDB
>> >
>> > [1] -
>> >
>> >
>> https://cwiki.apache.org/confluence/download/attachments/61322291/AsterixCodeFormatProfile.xml
>> > [2] -
>> > https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/
>> >
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message