atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 38341: Provide Entity Change Notification
Date Wed, 23 Sep 2015 03:58:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38341/
-----------------------------------------------------------

(Updated Sept. 23, 2015, 3:58 a.m.)


Review request for atlas, John Speidel and Shwetha GS.


Changes
-------

Updated diff


Bugs: ATLAS-158
    https://issues.apache.org/jira/browse/ATLAS-158


Repository: atlas


Description
-------

Add entity change notification to Atlas based using the existing atlas-notification module.

First cut at a patch for the Atlas entity change notification.  Note that at a minimum additional
unit tests are required.  I'm putting up the review to get some initial feedback.


Diffs (updated)
-----

  notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationConsumer.java
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationConsumerProvider.java
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java
PRE-CREATION 
  repository/pom.xml 8e4d0f3 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java fbd01de 
  repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 56168db 
  typesystem/src/main/java/org/apache/atlas/typesystem/EntityImpl.java PRE-CREATION 
  typesystem/src/main/java/org/apache/atlas/typesystem/IdImpl.java PRE-CREATION 
  typesystem/src/main/java/org/apache/atlas/typesystem/TraitImpl.java PRE-CREATION 
  typesystem/src/main/java/org/apache/atlas/typesystem/api/Entity.java PRE-CREATION 
  typesystem/src/main/java/org/apache/atlas/typesystem/api/Id.java PRE-CREATION 
  typesystem/src/main/java/org/apache/atlas/typesystem/api/Trait.java PRE-CREATION 

Diff: https://reviews.apache.org/r/38341/diff/


Testing
-------

mvn clean test

All existing tests pass.

New unit tests added (more required).


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message