atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication
Date Thu, 03 Nov 2016 17:35:49 GMT


> On Nov. 3, 2016, 5:33 p.m., Apoorv Naik wrote:
> > webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java,
line 125
> > <https://reviews.apache.org/r/53426/diff/1/?file=1553045#file1553045line125>
> >
> >     Parameterized string instead of concatenation.
> >     
> >     ```java
> >     LOG.debug("Knox doFilter {}", httpRequest.getRequestURI());
> >     ```

Also encapsulate within if (LOG.isDebugEnabled) {} check. Right now there's a mix of debug
calls, some with this check and some without.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53426/#review154772
-----------------------------------------------------------


On Nov. 3, 2016, 1:09 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53426/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 1:09 p.m.)
> 
> 
> Review request for atlas, Ankita Sinha, keval bhatt, Madhan Neethiraj, Shwetha GS, and
Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1244
>     https://issues.apache.org/jira/browse/ATLAS-1244
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch includes new filter for Atlas to Support KnoxSSO Authentication.
> 
> 
> Diffs
> -----
> 
>   distro/src/conf/atlas-application.properties 0349ccc 
>   webapp/pom.xml 6dbd484 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 30200b5

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/filters/SSOAuthentication.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/filters/SSOAuthenticationProperties.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
595387a 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java
23d3d70 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java
8654716 
>   webapp/src/main/resources/spring-security.xml ea9aa94 
>   webapp/src/main/webapp/WEB-INF/web.xml 7c6bc6d 
>   webapp/src/test/webapp/WEB-INF/web.xml 1b152ee 
> 
> Diff: https://reviews.apache.org/r/53426/diff/
> 
> 
> Testing
> -------
> 
> Verified Knox SSO authentication.
> Verified basic authentication process
> Verified form based authentication process
> 
> All existing test cases passing.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message