atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 53595: Added minimal data structure for typedef calls
Date Wed, 09 Nov 2016 04:56:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53595/#review155405
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java (line 43)
<https://reviews.apache.org/r/53595/#comment225318>

    AtlasType.TypeCategory is not under org.apache.atlas.model package - only classes under
this package are used in REST interface.
    
    Please move AtlasType.TypeCategory to org.apache.atlas.model.typedef.AtlasTypeCategory
enum.



intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java (line 82)
<https://reviews.apache.org/r/53595/#comment225319>

    Please update toString(), equals() and hasCode() implementation to be consistent with
other classes in model package - like AtlasBaseTypeDef.



intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (line 209)
<https://reviews.apache.org/r/53595/#comment225320>

    Consider replacing the call to toTypeDefHeader() with:
    
     - new AtlasTypeDefHeader(enumDef.getGuid(), enumDef.getName(), TypeCategory.PRIMITIVE)
     - new AtlasTypeDefHeader(structDef.getGuid(), structDef.getName(), TypeCategory.STRUCT)
     - new AtlasTypeDefHeader(classificationDef.getGuid(), classificationDef.getName(), TypeCategory.CLASSIFICATION)
     - new AtlasTypeDefHeader(entityDef.getGuid(), entityDef.getName(), TypeCategory.ENTITY)
    
    to avoid calling getTypeCategory() from toTypeDefHeader().


- Madhan Neethiraj


On Nov. 9, 2016, 4:40 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53595/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 4:40 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma
Shivaprasad.
> 
> 
> Bugs: ATLAS-1278
>     https://issues.apache.org/jira/browse/ATLAS-1278
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added minimal data structure for typedef calls
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java d0cb209 
> 
> Diff: https://reviews.apache.org/r/53595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message