atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes
Date Wed, 23 Nov 2016 22:09:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54023/#review156786
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 40)
<https://reviews.apache.org/r/54023/#comment227080>

    I think dynamic selection of the converter is better for future-proofing the converters.



webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 49)
<https://reviews.apache.org/r/54023/#comment227077>

    AtlasErrorCode instead of manual string concatenation.


Overall looks good to me.

- Apoorv Naik


On Nov. 23, 2016, 11:17 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54023/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 11:17 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1319
>     https://issues.apache.org/jira/browse/ATLAS-1319
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated converter classes to handle struct type attributes
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java 5485efa

>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java ec0661d

>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java c146d72

>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 5238a75

>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java
c3dfb61 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java dc42f10

>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java 761c8a7

>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java
66be58e 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java
ba77c67 
>   webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java
15c41c8 
>   webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java
6ac9013 
>   webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java
ece483c 
>   webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java
fab051f 
>   webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java
f0b4b12 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java c245596

>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java f8e18bf 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 6dd21d1 
> 
> Diff: https://reviews.apache.org/r/54023/diff/
> 
> 
> Testing
> -------
> 
> - verified that creation of entity with struct type attribute is handled correctly by
EntityREST API
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message