atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 54092: ATLAS-1335: updated AtlasStructType to treat multi-value attribute similar to TypeSystem for backward compatibility
Date Mon, 28 Nov 2016 18:03:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54092/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 6:03 p.m.)


Review request for atlas.


Changes
-------

Added unit test to address the review comment. Vimal - thanks for the review.


Bugs: ATLAS-1335
    https://issues.apache.org/jira/browse/ATLAS-1335


Repository: atlas


Description
-------

TypeSystem requires that multi-valued attributes (i.e. upper > 1) use attribute type of
either array or map - TypeSystem.constructAttributeInfo().

Multi-valued attribute equivalent in AtlasStructType (i.e. attributes with Cardinality LIST
or SET) is handled differently - by adding array<> to the type specified for the attribute.
This was updated to be consistent with the implementation in TypeSystem, for backward compatibility.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 65726c3 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java ef12896 
  intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 156ed43 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 534f2a9 
  intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java 1a15232 

Diff: https://reviews.apache.org/r/54092/diff/


Testing
-------

updated unit tests and verified that unit tests pass succesfully


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message