From dev-return-10898-apmail-atlas-dev-archive=atlas.apache.org@atlas.incubator.apache.org Mon Nov 28 18:03:45 2016 Return-Path: X-Original-To: apmail-atlas-dev-archive@minotaur.apache.org Delivered-To: apmail-atlas-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF9C6191C9 for ; Mon, 28 Nov 2016 18:03:45 +0000 (UTC) Received: (qmail 61412 invoked by uid 500); 28 Nov 2016 18:03:45 -0000 Delivered-To: apmail-atlas-dev-archive@atlas.apache.org Received: (qmail 61353 invoked by uid 500); 28 Nov 2016 18:03:45 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 61342 invoked by uid 99); 28 Nov 2016 18:03:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2016 18:03:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 06D781AB778 for ; Mon, 28 Nov 2016 18:03:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.019 X-Spam-Level: X-Spam-Status: No, score=-5.019 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 8DHJNEpZjGFG for ; Mon, 28 Nov 2016 18:03:44 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id A02405F58F for ; Mon, 28 Nov 2016 18:03:43 +0000 (UTC) Received: (qmail 61315 invoked by uid 99); 28 Nov 2016 18:03:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2016 18:03:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 15F722F5ADB; Mon, 28 Nov 2016 18:03:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7297502394779992503==" MIME-Version: 1.0 Subject: Re: Review Request 54092: ATLAS-1335: updated AtlasStructType to treat multi-value attribute similar to TypeSystem for backward compatibility From: Madhan Neethiraj To: Vimal Sharma , Madhan Neethiraj , atlas Date: Mon, 28 Nov 2016 18:03:41 -0000 Message-ID: <20161128180341.5576.2369@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54092/ X-Sender: Madhan Neethiraj References: <20161126064114.27388.11199@reviews.apache.org> In-Reply-To: <20161126064114.27388.11199@reviews.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============7297502394779992503== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54092/ ----------------------------------------------------------- (Updated Nov. 28, 2016, 6:03 p.m.) Review request for atlas. Changes ------- Added unit test to address the review comment. Vimal - thanks for the review. Bugs: ATLAS-1335 https://issues.apache.org/jira/browse/ATLAS-1335 Repository: atlas Description ------- TypeSystem requires that multi-valued attributes (i.e. upper > 1) use attribute type of either array or map - TypeSystem.constructAttributeInfo(). Multi-valued attribute equivalent in AtlasStructType (i.e. attributes with Cardinality LIST or SET) is handled differently - by adding array<> to the type specified for the attribute. This was updated to be consistent with the implementation in TypeSystem, for backward compatibility. Diffs (updated) ----- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 65726c3 intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java ef12896 intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 156ed43 intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 534f2a9 intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java 1a15232 Diff: https://reviews.apache.org/r/54092/diff/ Testing ------- updated unit tests and verified that unit tests pass succesfully Thanks, Madhan Neethiraj --===============7297502394779992503==--