From dev-return-13593-apmail-atlas-dev-archive=atlas.apache.org@atlas.incubator.apache.org Sun Mar 5 11:07:50 2017 Return-Path: X-Original-To: apmail-atlas-dev-archive@minotaur.apache.org Delivered-To: apmail-atlas-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2FA5D19086 for ; Sun, 5 Mar 2017 11:07:50 +0000 (UTC) Received: (qmail 22760 invoked by uid 500); 5 Mar 2017 11:07:50 -0000 Delivered-To: apmail-atlas-dev-archive@atlas.apache.org Received: (qmail 22699 invoked by uid 500); 5 Mar 2017 11:07:50 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 22688 invoked by uid 99); 5 Mar 2017 11:07:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Mar 2017 11:07:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 00BEB1A0167 for ; Sun, 5 Mar 2017 11:07:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id SOCYxABqA1mk for ; Sun, 5 Mar 2017 11:07:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9BB7F5F39E for ; Sun, 5 Mar 2017 11:07:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D77C4E00C4; Sun, 5 Mar 2017 11:07:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id ABCBFC411E7; Sun, 5 Mar 2017 11:07:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3197085529368331565==" MIME-Version: 1.0 Subject: Review Request 57321: ATLAS-1630: fix incorrect pagination of results in basic search; use index-search when query is provided (#3) From: Madhan Neethiraj To: Madhan Neethiraj , atlas Date: Sun, 05 Mar 2017 11:07:46 -0000 Message-ID: <20170305110746.56165.74224@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57321/ X-Sender: Madhan Neethiraj Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============3197085529368331565== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57321/ ----------------------------------------------------------- Review request for atlas. Bugs: ATLAS-1630 https://issues.apache.org/jira/browse/ATLAS-1630 Repository: atlas Description ------- - updated basic-search implementation to use direct-index-search when query string is provided. This results in faster/accurate results - fixed incorrect pagination of results in basic search Diffs ----- repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java e1f0acd repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 8855246 repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java ad8f073 Diff: https://reviews.apache.org/r/57321/diff/1/ Testing ------- - verified that basic-search pagination issue is fixed Thanks, Madhan Neethiraj --===============3197085529368331565==--