atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david...@apache.org>
Subject Re: Review Request 61681: [ATLAS-1475]: Create Entity via UI : Currently a simple entity can be associated with any number of complex entities, which seems inconsistent.
Date Wed, 16 Aug 2017 11:05:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61681/#review183032
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 109 (patched)
<https://reviews.apache.org/r/61681/#comment259022>

    I suggest making this error message much more explicit. Something like 
    
    Creation / update of entity (guid='<guid>',type='<entitytype>') failed becsfor
attribute '<attrname>', because the attribute' type '<attributetype>' is not specified
in an ownedRef or InverseRef contraint in the EntityDef '<entitytype>'.



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 731 (patched)
<https://reviews.apache.org/r/61681/#comment259023>

    Is this logic legacy only code? If not I suggest we check the legacy flaf inthe relationshipDef
and issue the legacy specific error message mentiongi n constraints. 
    
    If we can hit this error using the new non-legacy relationships , I suggest introducing
a new explicit error message with text similar to the one I suggest but instead of mentioning
constraints mention that the attribute is not in the ends in the relationshipDef.


- David Radley


On Aug. 16, 2017, 8:34 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61681/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2017, 8:34 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1475
>     https://issues.apache.org/jira/browse/ATLAS-1475
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Ideally , a hive_column (simple entity) should be associated to only one hive_table (complex
entity). Currently via UI, complex entity is allowed to be created with a simple entity which
is already associated to another entity.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6fa1f606 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
b8fd70e5 
> 
> 
> Diff: https://reviews.apache.org/r/61681/diff/1/
> 
> 
> Testing
> -------
> 
> Validated using crete entity from UI, simple eneity restricted from getting associated
to complex entity if it has an active ownedRef/inverseRef
> 
> mvn clean install - in progress
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message