atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 69926: Classification Updater: Updated to not use hard coded qualifiedName
Date Fri, 08 Feb 2019 00:31:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69926/#review212648
-----------------------------------------------------------




tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java
Line 386 (original), 394 (patched)
<https://reviews.apache.org/r/69926/#comment298497>

    There could be multiple entities  for a  given unique attribute value; only restriction
is that for a  given type there could be only one entity. So, consider using typeName + ":"
+ uniqueName as the key into the map.



tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java
Lines 427 (patched)
<https://reviews.apache.org/r/69926/#comment298498>

    Shouldn't line #427 be:
    
      return (String) header.getAttribute(getUniqueAttribute(header.getTypeName());
      
    Currently, this statement returns the name of the uniqueAttribute; and not entity attribute
value.


- Madhan Neethiraj


On Feb. 8, 2019, 12:01 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69926/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2019, 12:01 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath
Subramanian.
> 
> 
> Bugs: ATLAS-3046
>     https://issues.apache.org/jira/browse/ATLAS-3046
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Using _EntityType.getUniqueAttribute_ using REST client.
> 
> 
> Diffs
> -----
> 
>   tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java
1e0b66dfc 
> 
> 
> Diff: https://reviews.apache.org/r/69926/diff/1/
> 
> 
> Testing
> -------
> 
> **Functional tests**
> - Using user defined entity type.
> - Using out of box types.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message